Fix issue 658: update test-log-stack-tracer after r4211.

Fix issue 658: update test-log-stack-tracer after r4211.

It appears that semi-automatic changes made to test's code were
incorrect. v8::Script::Compile returns wrapped JSFunction,
not SharedFunctionInfo.

Committed: http://code.google.com/p/v8/source/detail?r=4222

[mnaganov (inactive), 2010-03-23 11:07:24]

Kasper, may I ask you to review this fix, as you were the reviewer for Ivan's
change.

[Kasper Lund, 2010-03-23 11:53:28]

LGTM.

http://codereview.chromium.org/1169002/diff/1/2
File test/cctest/test-log-stack-tracer.cc (right):

http://codereview.chromium.org/1169002/diff/1/2#newcode215
test/cctest/test-log-stack-tracer.cc:215: ret_addr,
Indentation.

http://codereview.chromium.org/1169002/diff/1/2#newcode294
test/cctest/test-log-stack-tracer.cc:294: CHECK(!CompileRun(
I would create a local handle for the result and do CHECK(!result.IsEmpty())
separately.

http://codereview.chromium.org/1169002/diff/1/2#newcode303
test/cctest/test-log-stack-tracer.cc:303: sample.stack[0]);
Indentation.

http://codereview.chromium.org/1169002/diff/1/2#newcode305
test/cctest/test-log-stack-tracer.cc:305: sample.stack[1]);
Indentation.

http://codereview.chromium.org/1169002/diff/1/2#newcode316
test/cctest/test-log-stack-tracer.cc:316: CHECK(!CompileRun(
I would create a local handle for the result and do CHECK(!result.IsEmpty())
separately.

http://codereview.chromium.org/1169002/diff/1/2#newcode331
test/cctest/test-log-stack-tracer.cc:331: sample.stack[0]);
Indentation.

http://codereview.chromium.org/1169002/diff/1/2#newcode333
test/cctest/test-log-stack-tracer.cc:333: sample.stack[1]);
Indentation.

[mnaganov (inactive), 2010-03-23 12:39:18]

Thanks!

http://codereview.chromium.org/1169002/diff/1/2
File test/cctest/test-log-stack-tracer.cc (right):

http://codereview.chromium.org/1169002/diff/1/2#newcode215
test/cctest/test-log-stack-tracer.cc:215: ret_addr,
On 2010/03/23 11:53:28, Kasper Lund wrote:
> Indentation.

Done.

http://codereview.chromium.org/1169002/diff/1/2#newcode294
test/cctest/test-log-stack-tracer.cc:294: CHECK(!CompileRun(
On 2010/03/23 11:53:28, Kasper Lund wrote:
> I would create a local handle for the result and do CHECK(!result.IsEmpty())
> separately. 

Good point. Done.

http://codereview.chromium.org/1169002/diff/1/2#newcode303
test/cctest/test-log-stack-tracer.cc:303: sample.stack[0]);
On 2010/03/23 11:53:28, Kasper Lund wrote:
> Indentation.

Done.

http://codereview.chromium.org/1169002/diff/1/2#newcode305
test/cctest/test-log-stack-tracer.cc:305: sample.stack[1]);
On 2010/03/23 11:53:28, Kasper Lund wrote:
> Indentation.

Done.

http://codereview.chromium.org/1169002/diff/1/2#newcode316
test/cctest/test-log-stack-tracer.cc:316: CHECK(!CompileRun(
On 2010/03/23 11:53:28, Kasper Lund wrote:
> I would create a local handle for the result and do CHECK(!result.IsEmpty())
> separately. 

Done.

http://codereview.chromium.org/1169002/diff/1/2#newcode331
test/cctest/test-log-stack-tracer.cc:331: sample.stack[0]);
On 2010/03/23 11:53:28, Kasper Lund wrote:
> Indentation.

Done.

http://codereview.chromium.org/1169002/diff/1/2#newcode333
test/cctest/test-log-stack-tracer.cc:333: sample.stack[1]);
On 2010/03/23 11:53:28, Kasper Lund wrote:
> Indentation.

Done.

[iposva, 2010-03-23 17:42:10]

On 2010/03/23 11:07:24, Michail Naganov wrote:
> Kasper, may I ask you to review this fix, as you were the reviewer for Ivan's
> change.

Mikhail,

It would be really helpful if the rather tricky code in test-log-stack-tracer.cc
was a bit better documented. It is nearly impossible to figure out what the code
is attempting to test and how when it fails.

Thanks,
-Ivan