Initialization cleanups and couple other minor things:

Initialization cleanups and couple other minor things:
  fixed eglSwapInterval call;
  exit on keypress in teartest;
  inversed the meaning of -o flag in teartest.

[piman, 2010-03-23 20:25:28]

http://codereview.chromium.org/1168005/diff/1/2
File client/deps/glbench/src/egl_stuff.cc (right):

http://codereview.chromium.org/1168005/diff/1/2#newcode27
client/deps/glbench/src/egl_stuff.cc:27: native_window, NULL);
native_window should align with egl_display

http://codereview.chromium.org/1168005/diff/1/3
File client/deps/glbench/src/glx_stuff.cc (right):

http://codereview.chromium.org/1168005/diff/1/3#newcode11
client/deps/glbench/src/glx_stuff.cc:11: GLXContext glx_context = NULL;
this is file-private, right ? you should mark it static.

http://codereview.chromium.org/1168005/diff/1/3#newcode35
client/deps/glbench/src/glx_stuff.cc:35: attrib, &nelements);
you should CHECK(nelements>0)

http://codereview.chromium.org/1168005/diff/1/5
File client/deps/glbench/src/xlib_window.cc (right):

http://codereview.chromium.org/1168005/diff/1/5#newcode12
client/deps/glbench/src/xlib_window.cc:12: XVisualInfo *xlib_visinfo = NULL;
all of these should be named g_xlib_*, especially if they are shared across
units. It makes it clearer when it's used that it's a global. You can do that in
this CL or a follow-up one.

[Alexey Marinichev, 2010-03-23 20:40:51]

http://codereview.chromium.org/1168005/diff/1/2
File client/deps/glbench/src/egl_stuff.cc (right):

http://codereview.chromium.org/1168005/diff/1/2#newcode27
client/deps/glbench/src/egl_stuff.cc:27: native_window, NULL);
On 2010/03/23 20:25:28, piman wrote:
> native_window should align with egl_display

Done.

http://codereview.chromium.org/1168005/diff/1/3
File client/deps/glbench/src/glx_stuff.cc (right):

http://codereview.chromium.org/1168005/diff/1/3#newcode11
client/deps/glbench/src/glx_stuff.cc:11: GLXContext glx_context = NULL;
On 2010/03/23 20:25:28, piman wrote:
> this is file-private, right ? you should mark it static.

Done.

http://codereview.chromium.org/1168005/diff/1/3#newcode35
client/deps/glbench/src/glx_stuff.cc:35: attrib, &nelements);
On 2010/03/23 20:25:28, piman wrote:
> you should CHECK(nelements>0)

I did it in xlib_stuff.c, and forgot about this one.

http://codereview.chromium.org/1168005/diff/1/5
File client/deps/glbench/src/xlib_window.cc (right):

http://codereview.chromium.org/1168005/diff/1/5#newcode12
client/deps/glbench/src/xlib_window.cc:12: XVisualInfo *xlib_visinfo = NULL;
On 2010/03/23 20:25:28, piman wrote:
> all of these should be named g_xlib_*, especially if they are shared across
> units. It makes it clearer when it's used that it's a global. You can do that
in
> this CL or a follow-up one.

I'll do that in the next commit.

[piman, 2010-03-23 20:47:28]

LGTM