Issue 1167004: Adds the source ImageLoadingTracker to OnImageLoaded. I need this in a

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1167004: Adds the source ImageLoadingTracker to OnImageLoaded. I need this in a (Closed)

Created:
10 years, 9 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
Aaron Boodman, Finnur

CC:
chromium-reviews, John Grabowski, Erik does not do reviews, ben+cc_chromium.org, pam+watch_chromium.org, Aaron Boodman

Visibility:
Public.

Adds the source ImageLoadingTracker to OnImageLoaded. I need this in a callback so that I can identify where the image is coming from. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42283

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -17 lines)			Patch
M	chrome/browser/cocoa/extensions/browser_action_button.mm	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/cocoa/location_bar_view_mac.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/cocoa/location_bar_view_mac.mm	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/image_loading_tracker.h	View	1 chunk	+7 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/image_loading_tracker.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/gtk/browser_actions_toolbar_gtk.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/gtk/location_bar_view_gtk.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/gtk/location_bar_view_gtk.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/views/browser_actions_container.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/views/browser_actions_container.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/views/location_bar_view.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/views/location_bar_view.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

Finnur

10 years, 9 months ago (2010-03-22 22:14:49 UTC) #4

Yeah, this is fine. I actually have an identical change in my upcoming
changelist (my next merge is going to be fun). :)