Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1166002: Fix handling of Mac accelerated plugin layers across tab switch. (Closed)

Created:
10 years, 9 months ago by stuartmorgan
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix handling of Mac accelerated plugin layers across tab switch. A few related changes to make tab switching work with accelerated plugins: - Re-attach our layer to the view layer whenever it changes; using setWantsLayer: creates a layer that AppKit manages at will, so we can't rely on it. - Override setFrame: on our layer to ignore bogus values sent by the view's layer. - Notify the accelerated surface when our parent (and thus drawing context) changes, so it can associate its texture with the new context. BUG=37701 TEST=Load the pepper test plugin (or a CA plugin in a build with CA enabled) and switch tabs away and back. The plugin should still be visible. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42273

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -61 lines) Patch
M chrome/browser/renderer_host/accelerated_surface_container_mac.h View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/accelerated_surface_container_mac.cc View 3 chunks +21 lines, -17 lines 0 comments Download
M chrome/browser/renderer_host/accelerated_surface_container_manager_mac.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/accelerated_surface_container_manager_mac.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_mac.h View 3 chunks +12 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_mac.mm View 10 chunks +79 lines, -41 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
stuartmorgan
10 years, 9 months ago (2010-03-22 19:23:40 UTC) #1
Ken Russell (switch to Gerrit)
LGTM. Thanks for fixing this.
10 years, 9 months ago (2010-03-22 20:52:26 UTC) #2
pink (ping after 24hrs)
10 years, 9 months ago (2010-03-23 17:32:04 UTC) #3
nit

http://codereview.chromium.org/1166002/diff/1/7
File chrome/browser/renderer_host/render_widget_host_view_mac.mm (right):

http://codereview.chromium.org/1166002/diff/1/7#newcode1676
chrome/browser/renderer_host/render_widget_host_view_mac.mm:1676:
AcceleratedPluginLayer* plugin_layer = [[AcceleratedPluginLayer alloc]
objC should use objC naming: pluginLayer, etc.

Powered by Google App Engine
This is Rietveld 408576698