Issue 1166001: Add unit test to check for zero length dir in FTP PWD response. ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1166001: Add unit test to check for zero length dir in FTP PWD response. ... (Closed)

Created:
10 years, 9 months ago by inferno

Modified:
9 years, 7 months ago

Reviewers:
jschuh, Paweł Hajdan Jr.

CC:
chromium-reviews, darin-cc_chromium.org, Paweł Hajdan Jr., Chris Evans

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add unit test to check for zero length dir in FTP PWD response. BUG=38845 TEST=FtpNetworkTransactionTest.ZeroLengthDirInPWD Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42238

Patch Set 2 : '' #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -0 lines)			Patch
	M	net/ftp/ftp_network_transaction_unittest.cc	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

After fixing the comment LGTM. Thanks! http://codereview.chromium.org/1166001/diff/1/2 File net/ftp/ftp_network_transaction_unittest.cc (right): http://codereview.chromium.org/1166001/diff/1/2#newcode1130 net/ftp/ftp_network_transaction_unittest.cc:1130: TEST_F(FtpNetworkTransactionTest, ZeroLengthDirInPWD) { ...

10 years, 9 months ago (2010-03-22 17:54:13 UTC) #3

inferno

10 years, 9 months ago (2010-03-22 18:09:45 UTC) #4

added comment about test on top. will commit once bots turn green.

Expand Messages | Collapse Messages

Issue 1166001: Add unit test to check for zero length dir in FTP PWD response. ... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages