Issue 1164004: Add KEEP_SIZE state to notification panel and fixed misc bugs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1164004: Add KEEP_SIZE state to notification panel and fixed misc bugs. (Closed)

Created:
10 years, 9 months ago by oshima

Modified:
9 years, 6 months ago

Reviewers:
Sean Parent

CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr.

Visibility:
Public.

Description

Add KEEP_SIZE state to panel and fixed misc bugs. * Replaced "closed_by_user, update_pane_on_leave_" flags with KEEP_SIZE state. The panel moves to this state when a user interacts with the panel. It keeps its size unless a notification is added, or removed, or it has more space than neccessary when mouse leaves the panel. * Fixed the crash when the preferred size is calculated to zero (can happen depending on timing) by adding minimum size. * fixed wrong return type (bool -> int) * GetNewBounds was using the panel's bounds instead of notification's bounds. * Refactored and clean up in tests.. BUG=33306 TEST=added two more browser tests for state transition. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42282

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+231 lines, -128 lines)			Patch
M	chrome/browser/chromeos/notifications/balloon_view.h	View		2 chunks	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/notifications/balloon_view.cc	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	chrome/browser/chromeos/notifications/notification_browsertest.cc	View		3 chunks	+97 lines, -15 lines	0 comments	Download
M	chrome/browser/chromeos/notifications/notification_panel.h	View	1 2	5 chunks	+61 lines, -42 lines	0 comments	Download
M	chrome/browser/chromeos/notifications/notification_panel.cc	View	1 2	17 chunks	+72 lines, -63 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages

Issue 1164004: Add KEEP_SIZE state to notification panel and fixed misc bugs. (Closed)

Description

Patch Set 1 #

Patch Set 2 : " #

Patch Set 3 : " #

Messages