Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2124)

Unified Diff: chrome/browser/sync/engine/download_updates_command.cc

Issue 1161006: Make it clear what last_sync_timestamp actually tracks. Update (Closed)
Patch Set: Undo accidental patch-juggling mistake. Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/engine/download_updates_command.cc
diff --git a/chrome/browser/sync/engine/download_updates_command.cc b/chrome/browser/sync/engine/download_updates_command.cc
index c7ad790ec57d8c1c8b7de9ef4c2eda28e1211a8f..59d5e5e37d0f6399a7be6b8ecc8bd8e20d529823 100644
--- a/chrome/browser/sync/engine/download_updates_command.cc
+++ b/chrome/browser/sync/engine/download_updates_command.cc
@@ -39,8 +39,8 @@ void DownloadUpdatesCommand::ExecuteImpl(SyncSession* session) {
LOG(ERROR) << "Scoped dir lookup failed!";
return;
}
- LOG(INFO) << "Getting updates from ts " << dir->last_sync_timestamp();
- get_updates->set_from_timestamp(dir->last_sync_timestamp());
+ LOG(INFO) << "Getting updates from ts " << dir->last_download_timestamp();
+ get_updates->set_from_timestamp(dir->last_download_timestamp());
// We want folders for our associated types, always. If we were to set
// this to false, the server would send just the non-container items
@@ -67,10 +67,15 @@ void DownloadUpdatesCommand::ExecuteImpl(SyncSession* session) {
StatusController* status = session->status_controller();
if (!ok) {
status->increment_num_consecutive_errors();
- LOG(ERROR) << "PostClientToServerMessage() failed";
+ status->mutable_updates_response()->Clear();
+ LOG(ERROR) << "PostClientToServerMessage() failed during GetUpdates";
return;
}
status->mutable_updates_response()->CopyFrom(update_response);
+
+ LOG(INFO) << "GetUpdates from ts " << get_updates->from_timestamp()
+ << " returned " << update_response.get_updates().entries_size()
+ << " updates.";
}
void DownloadUpdatesCommand::SetRequestedTypes(
« no previous file with comments | « chrome/browser/importer/firefox_importer_unittest_utils.h ('k') | chrome/browser/sync/engine/process_updates_command.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698