Make it clear what last_sync_timestamp actually tracks. Update

chrome/browser/sync/sessions/status_controller_unittest.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/sessions/sync_session.h"
 #include "chrome/test/sync/engine/test_id_factory.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace browser_sync {
 namespace sessions {
@@ skipping 85 matching lines @@
   status.set_unsynced_handles(v2);
   EXPECT_FALSE(status.TestAndClearIsDirty());  // Test for deep comparison.
 }
 
 TEST_F(StatusControllerTest, StaysClean) {
   StatusController status(routes_);
   status.update_conflict_sets_built(true);
   EXPECT_FALSE(status.TestAndClearIsDirty());
   status.update_conflicts_resolved(true);
   EXPECT_FALSE(status.TestAndClearIsDirty());
-  status.set_got_new_timestamp();
-  EXPECT_FALSE(status.TestAndClearIsDirty());
 
   status.set_items_committed();
   EXPECT_FALSE(status.TestAndClearIsDirty());
 
   OrderedCommitSet commits(routes_);
   commits.AddCommitItem(0, syncable::Id(), syncable::BOOKMARKS);
   status.set_commit_set(commits);
   EXPECT_FALSE(status.TestAndClearIsDirty());
 }
 
@@ skipping 71 matching lines @@
 
   {
     ScopedModelSafeGroupRestriction r(&status, GROUP_PASSIVE);
     EXPECT_FALSE(status.update_progress().HasConflictingUpdates());
   }
 }
 
 TEST_F(StatusControllerTest, CountUpdates) {
   StatusController status(routes_);
   EXPECT_EQ(0, status.CountUpdates());
-  EXPECT_TRUE(status.got_zero_updates());
   ClientToServerResponse* response(status.mutable_updates_response());
   sync_pb::SyncEntity* entity1 = response->mutable_get_updates()->add_entries();
   sync_pb::SyncEntity* entity2 = response->mutable_get_updates()->add_entries();
   ASSERT_TRUE(entity1 != NULL && entity2 != NULL);
   EXPECT_EQ(2, status.CountUpdates());
-  EXPECT_FALSE(status.got_zero_updates());
 }
 
 // Test TotalNumConflictingItems
 TEST_F(StatusControllerTest, TotalNumConflictingItems) {
   StatusController status(routes_);
   TestIdFactory f;
   {
     ScopedModelSafeGroupRestriction r(&status, GROUP_UI);
     status.mutable_conflict_progress()->AddConflictingItemById(f.NewLocalId());
     status.mutable_conflict_progress()->AddConflictingItemById(f.NewLocalId());
@@ skipping 19 matching lines @@
   status.commit_response();
   status.mutable_commit_response();
   status.updates_response();
   status.mutable_updates_response();
   status.error_counters();
   status.syncer_status();
   status.num_server_changes_remaining();
   status.ComputeMaxLocalTimestamp();
   status.commit_ids();
   status.HasBookmarkCommitActivity();
-  status.got_zero_updates();
+  status.download_updates_succeeded();
+  status.server_says_nothing_more_to_download();
   status.group_restriction();
 }
 
 }  // namespace sessions
 }  // namespace browser_sync