Bookmark manager: Fix an issue with drag and drop over the tree....

Bookmark manager: Fix an issue with drag and drop over the tree.

BUG=None
TEST=Drag a folder in the tree. You should not be able to drop it on itself. You should only be able to drop it when there is a drop marker.



Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42286

[feldstein, 2010-03-22 23:25:09]

LGTM

http://codereview.chromium.org/1161004/diff/1/2
File chrome/browser/resources/bookmark_manager/main.html (right):

http://codereview.chromium.org/1161004/diff/1/2#newcode325
chrome/browser/resources/bookmark_manager/main.html:325:
console.info('handleRemoved', id, removeInfo);
Did you want to enable all these console logs?

http://codereview.chromium.org/1161004/diff/1/2#newcode911
chrome/browser/resources/bookmark_manager/main.html:911: var expextedEventCount;
s/expexted/expected

http://codereview.chromium.org/1161004/diff/1/2#newcode913
chrome/browser/resources/bookmark_manager/main.html:913: expextedEventCount =
dragData.elements.length;
This could cause issues when we enable copying bookmarks by holding control (i
think that is the copy key) though it depends on how it ends up getting
implemented.  I'm ok with it for now though.

[feldstein, 2010-03-22 23:25:28]

Sorry i should have discarded those comments

On 2010/03/22 23:25:09, feldstein wrote:
> LGTM
> 
> http://codereview.chromium.org/1161004/diff/1/2
> File chrome/browser/resources/bookmark_manager/main.html (right):
> 
> http://codereview.chromium.org/1161004/diff/1/2#newcode325
> chrome/browser/resources/bookmark_manager/main.html:325:
> console.info('handleRemoved', id, removeInfo);
> Did you want to enable all these console logs?
> 
> http://codereview.chromium.org/1161004/diff/1/2#newcode911
> chrome/browser/resources/bookmark_manager/main.html:911: var
expextedEventCount;
> s/expexted/expected
> 
> http://codereview.chromium.org/1161004/diff/1/2#newcode913
> chrome/browser/resources/bookmark_manager/main.html:913: expextedEventCount =
> dragData.elements.length;
> This could cause issues when we enable copying bookmarks by holding control (i
> think that is the copy key) though it depends on how it ends up getting
> implemented.  I'm ok with it for now though.