Issue 11603: I'm removing logging.h/.cc from wow_helper....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11603: I'm removing logging.h/.cc from wow_helper.... (Closed)

Created:
12 years, 1 month ago by Nicolas Sylvain

Modified:
9 years, 7 months ago

Reviewers:
rvargas (doing something else)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

I'm removing logging.h/.cc from wow_helper. We were using it for only 2 small DCHECKs, but now logging.h depends on a lot of other stuff in base, and it's a lot of work to port everything back in wow_helper (icu?) I don't think it's worth the trouble for only 2 dchecks. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=5650

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -12 lines)			Patch
M	sandbox/wow_helper/service64_resolver.cc	View	2	2 chunks	+0 lines, -2 lines	0 comments	Download
M	sandbox/wow_helper/wow_helper.cc	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	sandbox/wow_helper/wow_helper.vcproj	View		1 chunk	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages