Issue 116006: Mac: Make sure the popup is closed when losing focus in omnibox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 116006: Mac: Make sure the popup is closed when losing focus in omnibox. (Closed)

Created:
11 years, 7 months ago by Scott Hess - ex-Googler

Modified:
9 years, 6 months ago

Reviewers:
pink (ping after 24hrs)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Mac: Make sure the popup is closed when losing focus in omnibox. Moved detection from -controlTextDidEndEditing: to -control:textShouldEditEditing: in case any of the code depends on still having focus when this happens. http://crbug.com/12252 TEST=Type "word" in omnibox. Click on page. Popup should dissappear.

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	chrome/browser/autocomplete/autocomplete_edit_view_mac.mm	View		2 chunks	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages