Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: gcl.py

Issue 115996: Remove the tree open check since it's now a presubmit script. (Closed)
Patch Set: Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gcl.py
diff --git a/gcl.py b/gcl.py
index 38899518c8df11e2cfeeb9ede2e2c15306ab87d9..f5605955cc870b4b28ed629586fb3261d12d5723 100755
--- a/gcl.py
+++ b/gcl.py
@@ -187,15 +187,6 @@ def GetCodeReviewSetting(key):
return CODEREVIEW_SETTINGS.get(key, "")
-def IsTreeOpen():
- """Fetches the tree status and returns either True or False."""
- url = GetCodeReviewSetting('STATUS')
- status = ""
- if url:
- status = urllib2.urlopen(url).read()
- return status.find('0') == -1
-
-
def Warn(msg):
ErrorExit(msg, exit=False)
@@ -607,7 +598,7 @@ Basic commands:
[--send_mail] [--no_try] [--no_presubmit]
Uploads the changelist to the server for review.
- gcl commit change_name [--no_presubmit] [--force]
+ gcl commit change_name [--no_presubmit]
Commits the changelist to the repository.
gcl lint change_name
@@ -873,12 +864,6 @@ def Commit(change_info, args):
else:
args.remove("--no_presubmit")
- no_tree_status_check = ("--force" in args or "-f" in args)
- if not no_tree_status_check and not IsTreeOpen():
- print ("Error: The tree is closed. Try again later or use --force to force"
- " the commit. May the --force be with you.")
- return
-
commit_cmd = ["svn", "commit", "--non-recursive"]
filename = ''
if change_info.issue:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698