Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(855)

Unified Diff: gcl.py

Issue 115994: Remove the use of --non-recursive flag. (Closed)
Patch Set: Improved comment Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gcl.py
diff --git a/gcl.py b/gcl.py
index 38899518c8df11e2cfeeb9ede2e2c15306ab87d9..3a4503d9c8722559380b63fb00b7ae659d6d441d 100755
--- a/gcl.py
+++ b/gcl.py
@@ -879,7 +879,14 @@ def Commit(change_info, args):
" the commit. May the --force be with you.")
return
- commit_cmd = ["svn", "commit", "--non-recursive"]
+ # We face a problem with svn here: Let's say change 'bleh' modifies
+ # svn:ignore on dir1\. but another unrelated change 'pouet' modifies
+ # dir1\foo.cc. When the user `gcl commit bleh`, foo.cc is *also committed*.
+ # The only fix is to use --non-recursive but that has its issues too:
+ # Let's say if dir1 is deleted, --non-recursive must *not* be used otherwise
+ # you'll get "svn: Cannot non-recursively commit a directory deletion of a
+ # directory with child nodes". Yay...
+ commit_cmd = ["svn", "commit"]
filename = ''
if change_info.issue:
# Get the latest description from Rietveld.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698