Issue 115977: Enable TR1 in windows build for gmock's use in VS2008 SP1.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115977: Enable TR1 in windows build for gmock's use in VS2008 SP1. (Closed)

Created:
11 years, 6 months ago by awong

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, M-A Ruel

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Enable TR1 in windows build for gmock's use in VS2008 SP1.

Patch Set 1 #

Patch Set 2 : Adding essential.vsprops. #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	build/common.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	build/internal/essential.vsprops	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

It's kind of sad that http://www.google.com/search?q=site:src.chromium.org/svn+_HAS_TR1 didn't pick up this file http://src.chromium.org/svn/trunk/src/build/internal/essential.vsprops

11 years, 6 months ago (2009-05-31 14:50:36 UTC) #2

M-A Ruel

11 years, 6 months ago (2009-06-01 17:25:55 UTC) #3

Remember that changing a vsprops requires a clobber build before taking effect
so you'll need to alert people/ask me to clobber the try slaves, etc. Yay!

Also, I assume you tried in Windows/Release as a clobber build and didn't see
any obvious side-effect, if so, LGTM.

Expand Messages | Collapse Messages