Issue 115964: Rewrite the presubmit test to be much more hermetic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115964: Rewrite the presubmit test to be much more hermetic. (Closed)

Created:
11 years, 6 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Jói Sigurðsson

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Rewrite the presubmit test to be much more hermetic. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17314

Patch Set 1 #

Patch Set 2 : 80 cols #

Total comments: 1

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+238 lines, -207 lines)			Patch
	M	tests/presubmit_unittest.py	View	1	21 chunks	+238 lines, -207 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

Sadly the test is longer but it is much more hermetic and the mock control ...

11 years, 6 months ago (2009-05-30 02:06:37 UTC) #1

Jói Sigurðsson

11 years, 6 months ago (2009-05-30 12:06:45 UTC) #2

LGTM

http://codereview.chromium.org/115964/diff/1002/3
File tests/presubmit_unittest.py (right):

http://codereview.chromium.org/115964/diff/1002/3#newcode37
Line 37: # Stub out 'os' but keep os.path.join().
maybe update the comment since you're keeping more than that?

Expand Messages | Collapse Messages