Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 11596: Cleanup RenderThemeWin. (Closed)

Created:
12 years, 1 month ago by Dean McNamee
Modified:
9 years, 7 months ago
Reviewers:
tony, ojan
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Try to bring a bit more structure to RenderThemeWin. This will help as Mac and Linux try to match it. - Remove trailing whitespace and extra newlines. - Reorder some declarations in the header to better group similar methods. - Drop unimplemented declaration of addIntrinsicMargins. - Implement the empty RenderThemeWin constructor and destructor in the header file. - Reorder all implementations to match declaration order. - Move the enums into the anonymous namespace. - Don't indent in an anonymous namespace. - Move all internal static helpers together.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+356 lines, -362 lines) Patch
M src/webkit/port/rendering/RenderThemeWin.h View 5 chunks +11 lines, -13 lines 0 comments Download
M src/webkit/port/rendering/RenderThemeWin.cpp View 18 chunks +345 lines, -349 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Dean McNamee
This patch is gnarly, sorry. It compiles, that's about the most I can say. This ...
12 years, 1 month ago (2008-11-22 22:52:43 UTC) #1
tony
12 years, 1 month ago (2008-11-23 02:48:55 UTC) #2
LG.

On 2008/11/22 22:52:43, Dean McNamee wrote:
> This patch is gnarly, sorry.  It compiles, that's about the most I can say.
> 
> This will really help in getting RenderThemeGtk to match.  The render theme
> stuff is a ton of virtual overrides, and right now it's really hard to tell
> whose implement what, or what we're missing, etc.  This helps a lot.
> 
> No code change (hopefully).

Powered by Google App Engine
This is Rietveld 408576698