Issue 115930: Clean-up temporary files/folders in firefox importer tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115930: Clean-up temporary files/folders in firefox importer tests. (Closed)

Created:
11 years, 6 months ago by Munjal (Google)

Modified:
9 years ago

Reviewers:
Nicolas Sylvain, M-A Ruel

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Clean-up temporary files/folders in firefox importer tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17238

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -0 lines)			Patch
M	chrome/browser/importer/firefox_importer_unittest.cc	View	1	4 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/chrome.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	chrome/test/file_test_utils.h	View		1 chunk	+24 lines, -0 lines	0 comments	Download
A	chrome/test/file_test_utils.cc	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	chrome/test/unit/unittests.vcproj	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Munjal (Google)

Nicolas/Marc, This is the work item we talked about a month ago - delete temporary ...

11 years, 6 months ago (2009-05-29 17:34:14 UTC) #1

Munjal (Google)

Can you take a look again? I didn't have file_test_utils.h/.cc in the first patch-set. I ...

11 years, 6 months ago (2009-05-29 17:49:45 UTC) #3

LGTM