Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Unified Diff: upload.py

Issue 115926: Use os.path.join() instead of hardcoding / (Closed)
Patch Set: Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: upload.py
diff --git a/upload.py b/upload.py
index bd29b2f7d2a8f749a0acb6e6964c01e1d4bbd0c1..971c51b0f92fa6f2da041cc105bada6b9f96d2a4 100755
--- a/upload.py
+++ b/upload.py
@@ -78,7 +78,8 @@ def GetEmail():
for next time we prompt.
"""
- last_email_file_name = os.path.expanduser("~/.last_codereview_email_address")
+ last_email_file_name = os.path.expanduser(
+ os.path.join("~", ".last_codereview_email_address"))
last_email = ""
prompt = "Email: "
if os.path.exists(last_email_file_name):
@@ -373,7 +374,8 @@ class HttpRpcServer(AbstractRpcServer):
opener.add_handler(urllib2.HTTPSHandler())
opener.add_handler(urllib2.HTTPErrorProcessor())
if self.save_cookies:
- self.cookie_file = os.path.expanduser("~/.codereview_upload_cookies")
+ self.cookie_file = os.path.expanduser(
+ os.path.join("~", ".codereview_upload_cookies"))
self.cookie_jar = cookielib.MozillaCookieJar(self.cookie_file)
if os.path.exists(self.cookie_file):
try:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698