Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1474)

Issue 115923: Remove SVN-specific function InputApi.FilterTextFiles(). (Closed)

Created:
11 years, 6 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
Jói Sigurðsson
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Remove SVN-specific function InputApi.FilterTextFiles(). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17202

Patch Set 1 #

Patch Set 2 : Fix unit test #

Patch Set 3 : Leverage mox.MoxTestBase #

Patch Set 4 : Dead code cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -83 lines) Patch
M presubmit_support.py View 4 chunks +22 lines, -47 lines 0 comments Download
M tests/presubmit_unittest.py View 1 2 3 8 chunks +31 lines, -36 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
M-A Ruel
I'm sad I didn't know mox.MoxTestBase before, it's quite useful.
11 years, 6 months ago (2009-05-29 14:47:44 UTC) #1
Jói Sigurðsson
11 years, 6 months ago (2009-05-29 18:31:51 UTC) #2
LGTM

MoxTestBase does seem very useful, will keep it in mind for my next Python
stuff.

Powered by Google App Engine
This is Rietveld 408576698