Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 115893: Add alert box suppression check box to linux js dialogs. (Closed)

Created:
11 years, 6 months ago by tony
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add alert box suppression check box to linux js dialogs. BUG=12174

Patch Set 1 #

Total comments: 1

Patch Set 2 : stash #

Total comments: 3

Patch Set 3 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -24 lines) Patch
M chrome/browser/app_modal_dialog_gtk.cc View 1 2 6 chunks +57 lines, -24 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tony
11 years, 6 months ago (2009-05-28 23:10:28 UTC) #1
Evan Martin
http://codereview.chromium.org/115893/diff/1/2 File chrome/browser/app_modal_dialog_gtk.cc (right): http://codereview.chromium.org/115893/diff/1/2#newcode43 Line 43: results = gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(item->data)); Can't you stash the toggle ...
11 years, 6 months ago (2009-05-28 23:13:36 UTC) #2
tony
On 2009/05/28 23:13:36, Evan Martin wrote: > http://codereview.chromium.org/115893/diff/1/2 > File chrome/browser/app_modal_dialog_gtk.cc (right): > > http://codereview.chromium.org/115893/diff/1/2#newcode43 ...
11 years, 6 months ago (2009-05-28 23:36:06 UTC) #3
Evan Martin
11 years, 6 months ago (2009-05-28 23:47:31 UTC) #4
LGTM

http://codereview.chromium.org/115893/diff/1003/4
File chrome/browser/app_modal_dialog_gtk.cc (right):

http://codereview.chromium.org/115893/diff/1003/4#newcode21
Line 21: const char kPromptTextId[] = "prompt_text";
maybe prefix with chrome_ just in case

http://codereview.chromium.org/115893/diff/1003/4#newcode31
Line 31: result = UTF8ToWide(gtk_entry_get_text(GTK_ENTRY(widget)));
if (widget)
  return UTF8ToWide(...);
return EmptyString() ?

http://codereview.chromium.org/115893/diff/1003/4#newcode42
Line 42: result = gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(widget));
same as above?

Powered by Google App Engine
This is Rietveld 408576698