Issue 115885: Hoist TrimHttpPrefix() so we only have one copy, not one per provider....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115885: Hoist TrimHttpPrefix() so we only have one copy, not one per provider.... (Closed)

Created:
11 years, 7 months ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Hoist TrimHttpPrefix() so we only have one copy, not one per provider. Make use of this in HistoryContentsProvider so results from it get their schemes trimmed appropriately. BUG=10558 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17145

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -55 lines)			Patch
M	chrome/browser/autocomplete/autocomplete.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete.cc	View	2 chunks	+21 lines, -0 lines	0 comments	Download
M	chrome/browser/autocomplete/history_contents_provider.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/autocomplete/history_contents_provider.cc	View	3 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/autocomplete/history_url_provider.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/autocomplete/history_url_provider.cc	View	2 chunks	+1 line, -22 lines	0 comments	Download
M	chrome/browser/autocomplete/search_provider.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/autocomplete/search_provider.cc	View	2 chunks	+2 lines, -24 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM