Issue 115877: linux: simplify gfx::Font constructor logic and add CHECK()s.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115877: linux: simplify gfx::Font constructor logic and add CHECK()s. (Closed)

Created:
11 years, 7 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
ukai, James Hawkins

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

linux: simplify gfx::Font constructor logic and add CHECK()s. Trying to track down a bug that a user is seeing. The getter we were using to extract the value before was for a debugger-compatible string. Perhaps it was the quote-removal code that was getting us before; if not, these CHECKs will track it down. BUG=12530

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -44 lines)			Patch
	M	app/gfx/font_gtk.cc	View		2 chunks	+38 lines, -43 lines	0 comments	Download
	M	app/gfx/font_skia.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

jhawkins: for review ukai: on CC since some of this is your code

11 years, 7 months ago (2009-05-28 20:58:53 UTC) #1

ukai

11 years, 6 months ago (2009-05-29 02:10:19 UTC) #3

On 2009/05/28 20:58:53, Evan Martin wrote:
> jhawkins: for review
> ukai: on CC since some of this is your code

Thanks. looks good to me.

Expand Messages | Collapse Messages