Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(829)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 115870: Reduce header dependencies in net/ (Closed)

Created:
11 years, 7 months ago by Paweł Hajdan Jr.
Modified:
9 years, 7 months ago
Reviewers:
eroman
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Reduce header dependencies in net/ TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17178

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -19 lines) Patch
M chrome/browser/automation/url_request_slow_download_job.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chrome_plugin_host.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/dom_ui/chrome_url_data_manager.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/buffered_resource_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/renderer_host/safe_browsing_resource_handler.cc View 1 chunk +1 line, -0 lines 1 comment Download
M chrome/common/net/url_request_intercept_job.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/plugin/chrome_plugin_host.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/base/bzip2_filter_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/base/dns_resolution_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M net/base/file_stream.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/base/file_stream_posix.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/base/file_stream_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/base/filter.h View 1 chunk +7 lines, -2 lines 0 comments Download
M net/base/filter.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/base/gzip_filter_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/base/listen_socket.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/base/net_module.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/base/sdch_filter.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/base/sdch_filter_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/base/socket.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/base/socket_test_util.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/base/ssl_client_socket_mac.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/base/ssl_client_socket_nss.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/base/ssl_client_socket_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/base/ssl_client_socket_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/base/ssl_info.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/base/tcp_client_socket_libevent.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/base/tcp_client_socket_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/base/tcp_client_socket_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/base/upload_data.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/base/upload_data_stream.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/base/upload_data_stream.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/http/http_network_transaction.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/http/http_network_transaction.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/proxy/proxy_script_fetcher.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/url_request/url_request.h View 2 chunks +1 line, -1 line 0 comments Download
M net/url_request/url_request_file_dir_job.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/url_request/url_request_file_job.h View 1 chunk +4 lines, -1 line 0 comments Download
M net/url_request/url_request_file_job.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/url_request/url_request_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_ftp_job.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/url_request/url_request_inet_job.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/url_request/url_request_job_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/url_request/url_request_new_ftp_job.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/url_request/url_request_new_ftp_job.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/url_request/url_request_simple_job.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/url_request/url_request_test_job.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/url_request/url_request_view_cache_job.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/tools/test_shell/simple_resource_loader_bridge.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell_win.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Paweł Hajdan Jr.
I recently started headers cleanups in various areas. This is cleanup in net. Didn't improve ...
11 years, 7 months ago (2009-05-28 19:04:23 UTC) #1
eroman
11 years, 7 months ago (2009-05-28 19:25:55 UTC) #2 
LGTM

http://codereview.chromium.org/115870/diff/1/7
File chrome/browser/renderer_host/safe_browsing_resource_handler.cc (right):

http://codereview.chromium.org/115870/diff/1/7#newcode7
Line 7: #include "net/base/net_errors.h"
shouldn't this be ordered lower down?

Powered by Google App Engine
This is Rietveld 408576698