Issue 115869: Moving things a little so this will work when chrome.sln gets eaten by gyp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115869: Moving things a little so this will work when chrome.sln gets eaten by gyp. (Closed)

Created:
11 years, 6 months ago by bradn

Modified:
9 years, 7 months ago

Reviewers:
sgk

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/

Visibility:
Public.

Description

Moving things a little so this will work when chrome.sln gets eaten by gyp. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17117

Patch Set 2 : '' #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+311 lines, -304 lines)			Patch
	M	chrome/app/locales/locales.gyp	View	1	3 chunks	+310 lines, -304 lines	0 comments	Download
	M	chrome/chrome.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sgk

lgtm, but let's use variables for the other paths, too. http://codereview.chromium.org/115869/diff/1/2 File chrome/app/locales/locales.gyp (right): http://codereview.chromium.org/115869/diff/1/2#newcode45 ...

11 years, 6 months ago (2009-05-28 18:52:28 UTC) #2

sweet, lgtm

Expand Messages | Collapse Messages

Issue 115869: Moving things a little so this will work when chrome.sln gets eaten by gyp. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages