Issue 115863: Move the Dictionary dir on the Mac out of the package and into user data....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115863: Move the Dictionary dir on the Mac out of the package and into user data.... (Closed)

Created:
11 years, 7 months ago by TVL

Modified:
9 years, 7 months ago

Reviewers:
Scott Hess - ex-Googler

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Move the Dictionary dir on the Mac out of the package and into user data. BUG=8317 TEST=make sure we don't create a dictionary directory within the app. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17079

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	chrome/common/chrome_paths.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

TVL

is there a unittest i should double check to make sure things are happy with ...

11 years, 7 months ago (2009-05-28 16:25:42 UTC) #1

Scott Hess - ex-Googler

11 years, 7 months ago (2009-05-28 17:17:19 UTC) #2

LGTM.

On 2009/05/28 16:25:42, TVL wrote:
> is there a unittest i should double check to make sure things are happy with
> this?

I assume SpellCheckTest still checks out?  I think Rohit patched things so that
it reads the dictionaries from the source tree (GetHunspellDirectory()), so I
think everything should Just Work.  Fingers crossed.

Expand Messages | Collapse Messages