Handle filling up of memory buffer to make log processing in DevTools Profiler easier.

Handle filling up of memory buffer to make log processing in DevTools Profiler easier.

When profiler's memory buffer is filled up, profiling is stopped and it is ensured that the last record in the buffer is "profiler,\"pause\"" thus making the end of profiling session explicit. Otherwise DevTools Profiler would need to guess whether the current profiling session has been stopped.

Tested with Chromium.

Committed: http://code.google.com/p/v8/source/detail?r=2072

[Søren Thygesen Gjesse, 2009-05-28 13:23:35]

LGTM

http://codereview.chromium.org/115859/diff/1/2
File src/log-utils.cc (right):

http://codereview.chromium.org/115859/diff/1/2#newcode92
Line 92: if (is_sealed_) return 0;
Please use {} for one line if's.

http://codereview.chromium.org/115859/diff/1/2#newcode283
Line 283: if (pos_ != Log::Write(Log::message_buffer_, pos_)) {
I would suggest the following:

int written = Log::Write(Log::message_buffer_, pos_);
if (written != pos_ && write_failure_handler != NULL) {
  write_failure_handler();
}

http://codereview.chromium.org/115859/diff/1/2#newcode291
Line 291: if (len != Log::Write(str, len)) {
Ditto.

http://codereview.chromium.org/115859/diff/1/3
File src/log-utils.h (right):

http://codereview.chromium.org/115859/diff/1/3#newcode207
Line 207: static WriteFailureHandler write_failure_handler;
Please make the write_failure_handler member private and add a static setter.

[Mikhail Naganov, 2009-05-28 13:52:51]

Thanks!

http://codereview.chromium.org/115859/diff/1/2
File src/log-utils.cc (right):

http://codereview.chromium.org/115859/diff/1/2#newcode92
Line 92: if (is_sealed_) return 0;
On 2009/05/28 13:23:35, Søren Gjesse wrote:
> Please use {} for one line if's.

Done.

http://codereview.chromium.org/115859/diff/1/2#newcode283
Line 283: if (pos_ != Log::Write(Log::message_buffer_, pos_)) {
On 2009/05/28 13:23:35, Søren Gjesse wrote:
> I would suggest the following:
> 
> int written = Log::Write(Log::message_buffer_, pos_);
> if (written != pos_ && write_failure_handler != NULL) {
>   write_failure_handler();
> }

Done. Thanks for noticing.

http://codereview.chromium.org/115859/diff/1/2#newcode291
Line 291: if (len != Log::Write(str, len)) {
On 2009/05/28 13:23:35, Søren Gjesse wrote:
> Ditto.

Done.

http://codereview.chromium.org/115859/diff/1/3
File src/log-utils.h (right):

http://codereview.chromium.org/115859/diff/1/3#newcode207
Line 207: static WriteFailureHandler write_failure_handler;
On 2009/05/28 13:23:35, Søren Gjesse wrote:
> Please make the write_failure_handler member private and add a static setter.

Done.