Issue 115857: Add more arithmetic to x64 assembler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115857: Add more arithmetic to x64 assembler. (Closed)

Created:
11 years, 7 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add more arithmetic to x64 assembler. Committed: http://code.google.com/p/v8/source/detail?r=2070

Patch Set 3 : '' #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+140 lines, -84 lines)			Patch
M	src/x64/assembler-x64.h	View	1	6 chunks	+90 lines, -26 lines	0 comments	Download
M	src/x64/assembler-x64.cc	View		24 chunks	+48 lines, -52 lines	0 comments	Download
M	src/x64/assembler-x64-inl.h	View		4 chunks	+2 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

LGTM http://codereview.chromium.org/115857/diff/1/3 File src/x64/assembler-x64.h (right): http://codereview.chromium.org/115857/diff/1/3#newcode826 Line 826: // Emit a basic arithmetic instruction (i.e. ...

11 years, 7 months ago (2009-05-28 09:50:57 UTC) #2

William Hesse

11 years, 7 months ago (2009-05-28 12:57:42 UTC) #3

http://codereview.chromium.org/115857/diff/1/3
File src/x64/assembler-x64.h (right):

http://codereview.chromium.org/115857/diff/1/3#newcode826
Line 826: // Emit a basic arithmetic instruction (i.e. first byte of the family
is 0x81)
On 2009/05/28 09:50:57, Lasse Reichstein wrote:
> I don't understand the parenthesis - what is a "family" in this case?
> 
Rewritten

Expand Messages | Collapse Messages

Issue 115857: Add more arithmetic to x64 assembler. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages