Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 115857: Add more arithmetic to x64 assembler. (Closed)

Created:
11 years, 7 months ago by William Hesse
Modified:
9 years, 7 months ago
Reviewers:
Lasse Reichstein
CC:
v8-dev
Visibility:
Public.

Description

Add more arithmetic to x64 assembler. Committed: http://code.google.com/p/v8/source/detail?r=2070

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -84 lines) Patch
M src/x64/assembler-x64.h View 1 6 chunks +90 lines, -26 lines 0 comments Download
M src/x64/assembler-x64.cc View 24 chunks +48 lines, -52 lines 0 comments Download
M src/x64/assembler-x64-inl.h View 4 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
William Hesse
11 years, 7 months ago (2009-05-28 09:28:59 UTC) #1
Lasse Reichstein
LGTM http://codereview.chromium.org/115857/diff/1/3 File src/x64/assembler-x64.h (right): http://codereview.chromium.org/115857/diff/1/3#newcode826 Line 826: // Emit a basic arithmetic instruction (i.e. ...
11 years, 7 months ago (2009-05-28 09:50:57 UTC) #2
William Hesse
11 years, 7 months ago (2009-05-28 12:57:42 UTC) #3
http://codereview.chromium.org/115857/diff/1/3
File src/x64/assembler-x64.h (right):

http://codereview.chromium.org/115857/diff/1/3#newcode826
Line 826: // Emit a basic arithmetic instruction (i.e. first byte of the family
is 0x81)
On 2009/05/28 09:50:57, Lasse Reichstein wrote:
> I don't understand the parenthesis - what is a "family" in this case?
> 
Rewritten

Powered by Google App Engine
This is Rietveld 408576698