Detach verify thread from PR on linux....

Detach verify thread from NSPR on linux.

The threads in our thread pool terminate after we have called
PR_Cleanup.  Unless we detach them from NSPR, if we use
CertVerifier, net_unittests dies with segfault on shutdown.

BUG=10911
TEST=net_unittests passes with code that uses CertVerifier.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17160

[wtc, 2009-05-28 17:34:50]

LGTM.  Please fix the following problems before checking
this in.  Thanks!

http://codereview.chromium.org/115856/diff/1/2
File net/base/cert_verifier.cc (right):

http://codereview.chromium.org/115856/diff/1/2#newcode8
Line 8: #include <nspr/private/pprthred.h>  // PR_DetatchThread
This should be just <private/pprthred.h> because on some
Linux distributions the NSPR headers are installed in
/usr/include/nspr4.

http://codereview.chromium.org/115856/diff/1/2#newcode44
Line 44: // Detach the thread.
Add "from NSPR".

http://codereview.chromium.org/115856/diff/1/2#newcode45
Line 45: // Unless we detach, the threads in our thread pool terminate after
This should read:
  Calling NSS functions attaches the thread to NSPR, which
  stores the NSPR thread ID in thread-specific data.
  The threads in our thread pool terminate after we have
  called PR_Cleanup.  Unless we detach them from NSPR,
  net_unittests gets segfault on shutdown when the
  threads' thread-specific data destructors run.

[ukai, 2009-05-29 02:33:25]

Thanks for review.

http://codereview.chromium.org/115856/diff/1/2
File net/base/cert_verifier.cc (right):

http://codereview.chromium.org/115856/diff/1/2#newcode8
Line 8: #include <nspr/private/pprthred.h>  // PR_DetatchThread
On 2009/05/28 17:34:50, wtc wrote:
> This should be just <private/pprthred.h> because on some
> Linux distributions the NSPR headers are installed in
> /usr/include/nspr4.

Done.

http://codereview.chromium.org/115856/diff/1/2#newcode44
Line 44: // Detach the thread.
On 2009/05/28 17:34:50, wtc wrote:
> Add "from NSPR".

Done.

http://codereview.chromium.org/115856/diff/1/2#newcode45
Line 45: // Unless we detach, the threads in our thread pool terminate after
On 2009/05/28 17:34:50, wtc wrote:
> This should read:
>   Calling NSS functions attaches the thread to NSPR, which
>   stores the NSPR thread ID in thread-specific data.
>   The threads in our thread pool terminate after we have
>   called PR_Cleanup.  Unless we detach them from NSPR,
>   net_unittests gets segfault on shutdown when the
>   threads' thread-specific data destructors run.

Done.

[wtc, 2009-05-29 02:35:31]

LGTM.