Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 115855: Improve debugger property lookup (Closed)

Created:
11 years, 6 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
Reviewers:
apavlov, yurys
CC:
v8-dev, apavlov1
Visibility:
Public.

Description

Improve debugger property lookup. before performing debugger property lookup make sure the current context is set to the context active before the debugger was entered. Make the use of the LookupResult GC safe in debugger property lookup. Committed: http://code.google.com/p/v8/source/detail?r=2071

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -13 lines) Patch
M src/runtime.cc View 1 2 3 chunks +29 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Søren Thygesen Gjesse
Could you please check whether this change gets rid of the crashes you have been ...
11 years, 6 months ago (2009-05-28 08:11:00 UTC) #1
yurys
LGTM, we will check if this fixes the craches we ovserved yesterday in the remote ...
11 years, 6 months ago (2009-05-28 08:48:21 UTC) #2
Søren Thygesen Gjesse
http://codereview.chromium.org/115855/diff/1001/2001 File src/runtime.cc (left): http://codereview.chromium.org/115855/diff/1001/2001#oldcode5522 Line 5522: if (Debug::debugger_entry()) { On 2009/05/28 08:48:21, Yury Semikhatsky ...
11 years, 6 months ago (2009-05-28 11:16:55 UTC) #3
apavlov
11 years, 6 months ago (2009-05-28 11:45:43 UTC) #4
Thanks for the patch. It does fix the crash for me!

Powered by Google App Engine
This is Rietveld 408576698