Issue 115854: Remove the gmock unittest example from the build as it causes link errors in XP Modules.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115854: Remove the gmock unittest example from the build as it causes link errors in XP Modules. (Closed)

Created:
11 years, 7 months ago by awong

Modified:
9 years, 7 months ago

Reviewers:
John Grabowski

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Remove the gmock unittest example from the build as it causes link errors in XP Modules.

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	base/base.gyp	View		2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

awong

tbr=jrg Somehow, this keeps breaking XP Modules when I checkin. The rest of the gmock ...

11 years, 7 months ago (2009-05-28 06:54:01 UTC) #1

awong

Build errors for reference: http://build.chromium.org/buildbot/waterfall/builders/Modules%20XP/builds/9763/steps/compile/logs/stdio http://build.chromium.org/buildbot/waterfall/builders/Modules%20XP%20(dbg)/builds/9705

11 years, 7 months ago (2009-05-28 06:56:49 UTC) #2

awong

11 years, 7 months ago (2009-05-28 07:41:47 UTC) #3

Okay, nevermind. It just worked on a resubmit.  Yay! It's in!

http://src.chromium.org/viewvc/chrome?view=rev&revision=17068

Not sure why it worked. Not questioning.


On 2009/05/28 06:56:49, awong wrote:
> Build errors for reference:
> 
>
http://build.chromium.org/buildbot/waterfall/builders/Modules%20XP/builds/976...
> 
>
http://build.chromium.org/buildbot/waterfall/builders/Modules%20XP%20(dbg)/bu...

Expand Messages | Collapse Messages