Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 115853: Switching locales projects to be semi gyp generated.... (Closed)

Created:
11 years, 7 months ago by bradn
Modified:
9 years, 7 months ago
Reviewers:
sgk
CC:
chromium-reviews_googlegroups.com
Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/
Visibility:
Public.

Description

Switching locales projects to be semi gyp generated. Initially these will be drop in replacements for the existing projects. These were generated mechanically in lieu of a looping syntax. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17070

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+639 lines, -8452 lines) Patch
M build/all.gyp View 1 chunk +1 line, -0 lines 1 comment Download
D chrome/app/locales/ar.vcproj View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/app/locales/bg.vcproj View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/app/locales/bn.vcproj View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/app/locales/ca.vcproj View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/app/locales/cs.vcproj View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/app/locales/da.vcproj View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/app/locales/de.vcproj View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/app/locales/el.vcproj View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/app/locales/en-GB.vcproj View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/app/locales/en-US.vcproj View 1 chunk +0 lines, -171 lines 0 comments Download
D chrome/app/locales/es.vcproj View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/app/locales/es-419.vcproj View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/app/locales/et.vcproj View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/app/locales/fi.vcproj View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/app/locales/fil.vcproj View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/app/locales/fr.vcproj View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/app/locales/gu.vcproj View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/app/locales/he.vcproj View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/app/locales/hi.vcproj View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/app/locales/hr.vcproj View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/app/locales/hu.vcproj View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/app/locales/id.vcproj View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/app/locales/it.vcproj View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/app/locales/ja.vcproj View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/app/locales/kn.vcproj View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/app/locales/ko.vcproj View 1 chunk +0 lines, -169 lines 0 comments Download
A chrome/app/locales/locales.gyp View 1 1 chunk +638 lines, -0 lines 1 comment Download
D chrome/app/locales/lt.vcproj View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/app/locales/lv.vcproj View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/app/locales/ml.vcproj View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/app/locales/mr.vcproj View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/app/locales/nb.vcproj View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/app/locales/nl.vcproj View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/app/locales/or.vcproj View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/app/locales/pl.vcproj View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/app/locales/pt-BR.vcproj View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/app/locales/pt-PT.vcproj View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/app/locales/ro.vcproj View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/app/locales/ru.vcproj View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/app/locales/sk.vcproj View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/app/locales/sl.vcproj View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/app/locales/sr.vcproj View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/app/locales/sv.vcproj View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/app/locales/ta.vcproj View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/app/locales/te.vcproj View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/app/locales/th.vcproj View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/app/locales/tr.vcproj View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/app/locales/uk.vcproj View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/app/locales/vi.vcproj View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/app/locales/zh-CN.vcproj View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/app/locales/zh-TW.vcproj View 1 chunk +0 lines, -169 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
bradn
Submitting this TBR.
11 years, 7 months ago (2009-05-28 08:19:00 UTC) #1
sgk
11 years, 7 months ago (2009-05-28 15:24:11 UTC) #2
http://codereview.chromium.org/115853/diff/106/1001
File build/all.gyp (right):

http://codereview.chromium.org/115853/diff/106/1001#newcode66
Line 66: '../chrome/app/locales/locales.gyp:*',
We need a similar addition to the 'pull_in_all' target in chrome\chrome.gyp, so
that the the generated chrome.sln builds everything the buildbots expect.

http://codereview.chromium.org/115853/diff/106/1030
File chrome/app/locales/locales.gyp (right):

http://codereview.chromium.org/115853/diff/106/1030#newcode37
Line 37: 'sources': [
These .rc files are all generated, right?  If so, there should be dependencies
(probably in 'target_defaults') on the targets that generate the .rc files.

Powered by Google App Engine
This is Rietveld 408576698