chrome/browser/external_tab_container.cc - Issue 115852: Restore parent semantings for external tab container creation, and error chec...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/external_tab_container.cc

Issue 115852: Restore parent semantings for external tab container creation, and error chec... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 11 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/external_tab_container.cc

===================================================================

--- chrome/browser/external_tab_container.cc (revision 17056)

+++ chrome/browser/external_tab_container.cc (working copy)

@@ -49,7 +49,11 @@

}

set_window_style(WS_POPUP);

- views::WidgetWin::Init(parent, bounds, true);

+ views::WidgetWin::Init(NULL, bounds, true);

+ if (!IsWindow()) {

+ NOTREACHED();

+ return false;

+ }

// We don't ever remove the prop because the lifetime of this object

// is the same as the lifetime of the window

« no previous file with comments | « no previous file | no next file » | no next file with comments »