Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 115849: Fixed a bug with the unit_tests, which caused it to leave hebrew enabled... (Closed)

Created:
11 years, 7 months ago by Hironori Bono
Modified:
9 years, 7 months ago
Reviewers:
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fixed a bug with the unit_tests, which caused it to leave hebrew enabled vista without hebrew support the bug reason is documented in the source for all to see and the bug=12093 (http://code.google.com/p/chromium/issues/detail?id=12093) the code has been tested with and without a debugger but i have to admit, the unit_tests rarely pass on my machine (the ui ones never do)but this code i changed leaves the state EXACTLY like it was and solves this issue at least BUG=12093 TEST=run unit_tests.exe on Hebrew Windows; run Chrome; open a page which contains a <textarea dir="ltr"></textarea> element; press control+right-shift key, and; verify its "dir" attribute becomes "rtl". Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17156

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -15 lines) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
MM chrome/renderer/mock_keyboard_driver_win.h View 1 2 2 chunks +8 lines, -2 lines 0 comments Download
MM chrome/renderer/mock_keyboard_driver_win.cc View 1 3 chunks +37 lines, -13 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698