This adds a DEPS file for o3d that maps in all of its dependencies,...

This adds a DEPS file for o3d that maps in all of its dependencies,
and updates the build files so that it will build.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17142

[Antoine Labour, 2009-05-28 21:09:29]

http://codereview.chromium.org/115847/diff/1/4
File main.scons (right):

http://codereview.chromium.org/115847/diff/1/4#newcode220
Line 220: AddPathToWindowsEnv(nacl_os_env, 'INCLUDE', env.subst('$NACL_DIR/..'))
If this is needed to compile nacl, how is it going to work on non-windows
platforms ?

[Greg Spencer, 2009-05-28 21:11:34]

As soon as this is checked in, O3D will be able to begin development in the
Chrome tree.

[Nicolas Sylvain, 2009-05-28 21:13:51]

Deps LGTM. I don't think it will cause any side effects. 
I haven't really looked at the rest

[Greg Spencer, 2009-05-28 23:27:40]

Also, I fixed up the scons files to point to the right place.

http://codereview.chromium.org/115847/diff/1/4
File main.scons (right):

http://codereview.chromium.org/115847/diff/1/4#newcode220
Line 220: AddPathToWindowsEnv(nacl_os_env, 'INCLUDE', env.subst('$NACL_DIR/..'))
On 2009/05/28 21:09:29, Antoine Labour wrote:
> If this is needed to compile nacl, how is it going to work on non-windows
> platforms ?

Hmm. Good point.  Turns out I had to do that because I had placed native_client
one level too far down, and it was trying to look for
[...]/googleclient/googleclient/.  Fixing that fixed the need for this include.

[Antoine Labour, 2009-05-29 00:04:11]

LGTM

[Mark Larson, 2009-05-30 09:27:55]

I know this is already checked in, but...

Why not have one entry in DEPS for 

"o3d/third_party":
"http://o3d.googlecode.com/svn/trunk/googleclient/third_party@" +
Var("o3d_code_rev"),

It would seem to simplify things. 

It might not matter if this has a short shelf life. If we continue to pull
o3d/third_party from codesite, however, this would make sure that you get
_everything_ under third_party at the given rev. 

You wouldn't have to add paths to DEPS if you add to (or remove from)
third_party. You just update the o3d_code_rev variable.