Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 115844: Add *_unittest.cc and *_uitest.cc modules left out of the gyp build:... (Closed)

Created:
11 years, 7 months ago by sgk
Modified:
9 years, 5 months ago
Reviewers:
bradnelson, bradn
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add *_unittest.cc and *_uitest.cc modules left out of the gyp build: * test/ui/sandbox_uitest.cc * test/ui/v8_benchmark_uitest.cc * worker/worker_uitest.cc * browser/autocomplete/search_provider_unittest.cc * browser/extensions/extension_process_manager_unittest.cc * browser/extensions/extension_view_unittest.cc * browser/find_backend_unittest.cc * browser/safe_browsing/safe_browsing_blocking_page_unittest.cc * browser/search_engines/template_url_scraper_unittest.cc Also the utility module: * test/ui/javascript_test_util.cc BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17065

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M chrome/chrome.gyp View 10 chunks +20 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
sgk
11 years, 7 months ago (2009-05-28 03:46:30 UTC) #1
bradn
11 years, 7 months ago (2009-05-28 03:52:08 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698