Issue 115841: Remove DataSourceImpl from chrome/renderer/media...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115841: Remove DataSourceImpl from chrome/renderer/media... (Closed)

Created:
11 years, 7 months ago by Alpha Left Google

Modified:
9 years, 6 months ago

Reviewers:
fbarchard, scherkus (not reviewing)

CC:
chromium-reviews_googlegroups.com, awong

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Remove DataSourceImpl from chrome/renderer/media Since media in chrome renderer doesn't use file handle anymore, and these two files are deprecated, remove them from the tree. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17046

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -538 lines)			Patch
	D	chrome/renderer/media/data_source_impl.h	View		1 chunk	+0 lines, -196 lines	0 comments	Download
	D	chrome/renderer/media/data_source_impl.cc	View		1 chunk	+0 lines, -342 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Alpha Left Google

first step of remove file handle code from chromium.

11 years, 7 months ago (2009-05-27 23:56:12 UTC) #1

Alpha Left Google

On 2009/05/28 00:19:10, scherkus wrote: > What about vcproj and gyp files? I removed the ...

11 years, 7 months ago (2009-05-28 00:22:03 UTC) #4

scherkus (not reviewing)

11 years, 7 months ago (2009-05-28 00:33:11 UTC) #5

Ahh I found it:
http://codereview.chromium.org/115059

For TBR reviews don't forget to add the reviewers and hit publish+mail. 
Otherwise it never shows up on chromium-reviews and in my inbox :)

Expand Messages | Collapse Messages