Issue 115833: With the recent change to the ExternalTabContainer to have it subclass Widget...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115833: With the recent change to the ExternalTabContainer to have it subclass Widget... (Closed)

Created:
11 years, 7 months ago by ananta

Modified:
9 years, 6 months ago

Reviewers:
amit

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

With the recent change to the ExternalTabContainer to have it subclass WidgetWin rather than Widget and the associated ATL classes, the class name based comparison for a window to check if it is an external tab container window is no longer valid. We now check if a window is an external tab window by looking for the existence of the kWindowObjectKey window property, which is only set on external tab container windows. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17034

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -4 lines)			Patch
M	chrome/browser/external_tab_container.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome/common/chrome_constants.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/chrome_constants.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages