Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 115832: Fix 12729: Find box doesn't unregister Esc accelerator.... (Closed)

Created:
11 years, 7 months ago by Finnur
Modified:
9 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix 12729: Find box doesn't unregister Esc accelerator. This regressed recently during porting. When comparing to see who is registered we need to be comparing against a class that implements FocusChangeListener (and registers as such with AddFocusChangeListener). In this case, host_ does not implement that interface and doesn't register as a listener, so it will never be registered. We should be comparing using 'this', not 'host_'. I've fixed this and added a browser_test to catch this in the future. BUG=12729 TEST=Open Find, press Esc, press Esc again and the Find box should not briefly appear and hide again. Also, make sure Esc works to cancel navigations. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17032

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -5 lines) Patch
M chrome/browser/views/find_bar_win.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/views/find_bar_win_browsertest.cc View 3 chunks +36 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Finnur
11 years, 7 months ago (2009-05-27 22:15:37 UTC) #1
sky
11 years, 7 months ago (2009-05-27 22:17:31 UTC) #2
LGTM

Sorry about that.

Powered by Google App Engine
This is Rietveld 408576698