Issue 115831: Converts a bunch things from NativeWindow to NativeView to make it...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115831: Converts a bunch things from NativeWindow to NativeView to make it... (Closed)

Created:
11 years, 7 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Converts a bunch things from NativeWindow to NativeView to make it easier for callers. Also gets bookmark menu button to compile. I'm also removing a function I just added to gtk_util as it's not needed. GTK offers gtk_widget_get_toplevel which does what I need. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17029

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -50 lines)			Patch
M	chrome/browser/bookmarks/bookmark_context_menu.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_context_menu.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_editor.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/bookmarks/bookmark_utils.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_utils.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/gtk/bookmark_bar_gtk.cc	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	chrome/browser/gtk/bookmark_editor_gtk.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/gtk/bookmark_menu_controller_gtk.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/input_window_dialog.h	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/input_window_dialog_gtk.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/input_window_dialog_win.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/bookmark_menu_button.cc	View	2 chunks	+10 lines, -0 lines	0 comments	Download
M	chrome/browser/views/bookmark_menu_controller_views.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/views/bookmark_menu_controller_views.cc	View	2 chunks	+3 lines, -8 lines	0 comments	Download
M	chrome/chrome.gyp	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/common/gtk_util.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/common/gtk_util.cc	View	1 chunk	+0 lines, -9 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages