Makes MenuButton compile and fixes bug in GtkWidget I happened upon....

views/widget/widget_gtk.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "views/widget/widget_gtk.h"
 
 #include "base/compiler_specific.h"
 #include "views/fill_layout.h"
 #include "views/widget/root_view.h"
 #include "views/window/window_gtk.h"
 
 namespace views {
 
 // Returns the position of a widget on screen.
 static void GetWidgetPositionOnScreen(GtkWidget* widget, int* x, int *y) {
-  GtkWidget* parent = widget;
-  while (parent) {
+  while (widget) {
     if (GTK_IS_WINDOW(widget)) {
       int window_x, window_y;
       gtk_window_get_position(GTK_WINDOW(widget), &window_x, &window_y);
       *x += window_x;
       *y += window_y;
       return;
     }
     // Not a window.
     *x += widget->allocation.x;
     *y += widget->allocation.y;
-    parent = gtk_widget_get_parent(parent);
+    widget = gtk_widget_get_parent(widget);
   }
 }
 
 // Returns the view::Event::flags for a GdkEventButton.
 static int GetFlagsForEventButton(const GdkEventButton& event) {
   int flags = Event::GetFlagsFromGdkState(event.state);
   switch (event.button) {
     case 1:
       flags |= Event::EF_LEFT_BUTTON_DOWN;
       break;
@@ skipping 436 matching lines @@
     return true;
   }
 
   last_mouse_event_was_move_ = false;
   MouseEvent mouse_pressed(Event::ET_MOUSE_PRESSED, event->x, event->y,
                            GetFlagsForEventButton(*event));
   if (root_view_->OnMousePressed(mouse_pressed)) {
     is_mouse_down_ = true;
     if (!has_capture_) {
       has_capture_ = true;
+      // TODO: this should also do a gdk_pointer_grab. See gtkmenu.cc for details:

[brettw, 2009/05/27 20:24:30]

Line too long, and remove the empty // line here.

+      // 
       gtk_grab_add(child_widget_parent_);
     }
     return true;
   }
 
   return false;
 }
 
 void WidgetGtk::ProcessMouseReleased(GdkEventButton* event) {
   last_mouse_event_was_move_ = false;
@@ skipping 179 matching lines @@
 void WidgetGtk::HandleGrabBroke() {
   if (has_capture_) {
     if (is_mouse_down_)
       root_view_->ProcessMouseDragCanceled();
     is_mouse_down_ = false;
     has_capture_ = false;
   }
 }
 
 }  // namespace views