Issue 115826: Makes MenuButton compile and fixes bug in GtkWidget I happened upon....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115826: Makes MenuButton compile and fixes bug in GtkWidget I happened upon.... (Closed)

Created:
11 years, 7 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Makes MenuButton compile and fixes bug in GtkWidget I happened upon. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17018

Patch Set 1 #

Total comments: 1

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -5 lines)			Patch
M	views/controls/button/menu_button.cc	View	5 chunks	+13 lines, -1 line	0 comments	Download
M	views/views.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	views/widget/widget_gtk.cc	View	3 chunks	+4 lines, -3 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

brettw

11 years, 7 months ago (2009-05-27 20:24:29 UTC) #2

LGTM

http://codereview.chromium.org/115826/diff/1/2
File views/widget/widget_gtk.cc (right):

http://codereview.chromium.org/115826/diff/1/2#newcode484
Line 484: // TODO: this should also do a gdk_pointer_grab. See gtkmenu.cc for
details:
Line too long, and remove the empty // line here.

Expand Messages | Collapse Messages