Issue 115823: Fix breakpad-related Linux official build breakage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115823: Fix breakpad-related Linux official build breakage. (Closed)

Created:
11 years, 7 months ago by Michael Moss

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang, jon, agl

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix breakpad-related Linux official build breakage. Move the "breakpad_linux*" files to the "browser" target rather than "app", since they're needed by "render_crash_handler_host_linux*" which is in "browser". This fixes link errors in unit_tests, which incorporates "browser" but wasn't getting the definitions in these files. This is a revised version of r16954 which avoids the scons "multiple inclusion" errors in the non-official build.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Clean up "app" target some more. #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -21 lines)			Patch
	M	chrome/chrome.gyp	View	1	2 chunks	+11 lines, -21 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

agl

LGTM with a nit below: http://codereview.chromium.org/115823/diff/1/2 File chrome/chrome.gyp (left): http://codereview.chromium.org/115823/diff/1/2#oldcode2093 Line 2093: 'include_dirs': [ Remove ...

11 years, 7 months ago (2009-05-27 18:58:52 UTC) #2

Michael Moss

11 years, 7 months ago (2009-05-27 19:35:22 UTC) #3

> http://codereview.chromium.org/115823/diff/1/2#oldcode2093
> Line 2093: 'include_dirs': [
> Remove this now?

Yeah, makes sense. Done.

Expand Messages | Collapse Messages