Issue 115818: Add shift-zoom to maximize....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115818: Add shift-zoom to maximize.... (Closed)

Created:
11 years, 7 months ago by pink (ping after 24hrs)

Modified:
9 years, 7 months ago

Reviewers:
stuartmorgan

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add shift-zoom to maximize. BUG=none TEST=shift-zoom maximizes window, zoom sizes to intrinsic size. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16989

Patch Set 1 #

Total comments: 1

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	chrome/browser/cocoa/browser_window_controller.mm	View		1 chunk	+8 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

stuartmorgan

11 years, 7 months ago (2009-05-27 16:05:07 UTC) #2

LGTM

http://codereview.chromium.org/115818/diff/1/2
File chrome/browser/cocoa/browser_window_controller.mm (right):

http://codereview.chromium.org/115818/diff/1/2#newcode238
Line 238: // |frame| isn't the full screen rect, and I'm not sure why. It should
be.
This comment should probably go, since frame isn't the right call here--it
includes the dock and the menu bar. visibleFrame is the right call for this use.

Expand Messages | Collapse Messages