Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 115817: Use correct branding on the "make default browser" button. Create a new local... (Closed)

Created:
11 years, 7 months ago by pink (ping after 24hrs)
Modified:
9 years, 7 months ago
Reviewers:
TVL
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Use correct branding on the "make default browser" button. Create a new localizer subclass for the prefs window. BUG=12534 TEST=make sure branding is correct on default browser button. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16991

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -11 lines) Patch
M chrome/app/nibs/en.lproj/Preferences.xib View 14 chunks +62 lines, -11 lines 0 comments Download
A chrome/browser/cocoa/preferences_localizer.h View 1 chunk +19 lines, -0 lines 1 comment Download
A chrome/browser/cocoa/preferences_localizer.mm View 1 chunk +28 lines, -0 lines 0 comments Download
M chrome/chrome.gyp View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
pink (ping after 24hrs)
11 years, 7 months ago (2009-05-27 15:02:11 UTC) #1
TVL
11 years, 7 months ago (2009-05-27 15:05:02 UTC) #2
lgtm

http://codereview.chromium.org/115817/diff/1/3
File chrome/browser/cocoa/preferences_localizer.h (right):

http://codereview.chromium.org/115817/diff/1/3#newcode16
Line 16: }
drop the {}

Powered by Google App Engine
This is Rietveld 408576698