Make the caption text for the "I understand" checkboxes in malware interstiti...

Make the caption text for the "I understand" checkboxes in malware interstitial pages into an HTML label tag, to make it clickable and more friendly to screen readers.

TEST= Navigate to ianfette.org and click on the text "I understand that visiting this site may harm my computer". Checkbox should toggle.

BUG=12714

[arv (Not doing code reviews), 2009-05-27 16:00:47]

This will not work.

The for attribute of a label element needs to be the ID of the element it is
associated with. In this case the checkbox does not have an ID. It has a name
but that is not enough. 

Instead of using the for attribute you can wrap the input with the label. See
inline comment.

http://codereview.chromium.org/115815/diff/1001/1003
File chrome/browser/resources/safe_browsing_malware_block.html (right):

http://codereview.chromium.org/115815/diff/1001/1003#newcode94
Line 94: <input name="checky" type="checkbox"
onclick="agreed(this.form)">&nbsp;<label for="checky"><span
jscontent="confirm_text"></span></label>
The simplest thing is to just wrap the checkbox and the text with the label:

<label><input ...>&nbsp;<span ...>...</span></label>

http://codereview.chromium.org/115815/diff/1001/1002
File chrome/browser/resources/safe_browsing_multiple_threat_block.html (right):

http://codereview.chromium.org/115815/diff/1001/1002#newcode134
Line 134: <input name="checky" type="checkbox"
onclick="agreed(this.form)">&nbsp;<label for="checky"><span
jscontent="confirm_text"></span></label>
same here

[WillH, 2009-05-27 17:05:27]

You're right. I think semantically it's preferable to identify the checkbox
specifically, as in the new patch set, and this seems to be the general practice
elsewhere.

[arv (Not doing code reviews), 2009-05-27 17:10:59]

http://codereview.chromium.org/115815/diff/8/10
File chrome/browser/resources/safe_browsing_malware_block.html (right):

http://codereview.chromium.org/115815/diff/8/10#newcode94
Line 94: <input name="checky" id="checky" type="checkbox"
onclick="agreed(this.form)">&nbsp;<label for="checky"><span
jscontent="confirm_text"></span></label>
Can you remove the span and move the jscontent to the label element?

http://codereview.chromium.org/115815/diff/8/9
File chrome/browser/resources/safe_browsing_multiple_threat_block.html (right):

http://codereview.chromium.org/115815/diff/8/9#newcode134
Line 134: <input name="checky" id="checky" type="checkbox"
onclick="agreed(this.form)">&nbsp;<label for="checky"><span
jscontent="confirm_text"></span></label>
Same here

[WillH, 2009-05-27 18:00:05]

Done.

[arv (Not doing code reviews), 2009-05-27 18:46:06]

LGTM

[WillH, 2009-05-28 00:16:46]

Cool. Appears I don't have commit access so could someone else please? Cheers

[arv (Not doing code reviews), 2009-05-28 00:25:31]

Ian, does this look OK with you?

[ian fette, 2009-05-28 00:33:47]

lgtm