Issue 115803: Fox some compilation problems for Linux. This also adds bookmark_bar_view to ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115803: Fox some compilation problems for Linux. This also adds bookmark_bar_view to ... (Closed)

Created:
11 years, 7 months ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fox some compilation problems for Linux. This also adds bookmark_bar_view and window_sizer to the Linux build. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16953

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -7 lines)			Patch
M	chrome/browser/bookmarks/bookmark_drag_data.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/browser.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_tabs_module.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/bookmark_menu_controller_views.cc	View	1	2 chunks	+7 lines, -3 lines	0 comments	Download
M	chrome/chrome.gyp	View	1	3 chunks	+6 lines, -0 lines	1 comment	Download
M	chrome/common/temp_scaffolding_stubs.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

11 years, 7 months ago (2009-05-26 23:20:07 UTC) #2

OK

http://codereview.chromium.org/115803/diff/1003/20
File chrome/chrome.gyp (right):

http://codereview.chromium.org/115803/diff/1003/20#newcode1700
Line 1700: ['include', '^browser/views/bookmark_menu_controller_views.c'],
.cc I think you mean

Expand Messages | Collapse Messages