Issue 115792: Control spacing of toolbar elements with pixels rather than " " GtkLabels....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115792: Control spacing of toolbar elements with pixels rather than " " GtkLabels.... (Closed)

Created:
11 years, 7 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
tony

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Control spacing of toolbar elements with pixels rather than " " GtkLabels. This fixes another large fonts issue. BUG=12573 TEST=toolbar should look like it does on windows (where there is spacing, the size of it, etc.) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16963

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -12 lines)			Patch
	M	chrome/browser/gtk/browser_toolbar_gtk.h	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
	M	chrome/browser/gtk/browser_toolbar_gtk.cc	View		7 chunks	+11 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tony

LGTM, one nit below. http://codereview.chromium.org/115792/diff/1/2 File chrome/browser/gtk/browser_toolbar_gtk.h (right): http://codereview.chromium.org/115792/diff/1/2#newcode85 Line 85: int spacing); Is this ...

11 years, 7 months ago (2009-05-26 21:11:31 UTC) #2

Evan Stade

11 years, 7 months ago (2009-05-26 21:13:01 UTC) #3

http://codereview.chromium.org/115792/diff/1/2
File chrome/browser/gtk/browser_toolbar_gtk.h (right):

http://codereview.chromium.org/115792/diff/1/2#newcode85
Line 85: int spacing);
On 2009/05/26 21:11:31, tony wrote:
> Is this the spacing before or after the button?

both. I'll make a comment.

Expand Messages | Collapse Messages