Issue 115789: Fix issue where cmd-w was hard-coded to closing a browser tab regardless of t...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115789: Fix issue where cmd-w was hard-coded to closing a browser tab regardless of t... (Closed)

Created:
11 years, 7 months ago by pink (ping after 24hrs)

Modified:
9 years, 7 months ago

Reviewers:
TVL

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix issue where cmd-w was hard-coded to closing a browser tab regardless of the frontmost window type. Have cmd-key equiv correctly set depending on the window type and the number of tabs in the window. Broadcast notification when the number of tabs changes in the model. Disable "close tab" item when there's only 1 tab in the browser window. BUG=10047 TEST=cmd-w correctly closes the expected thing (frontmost window, or tab in the frontmost window). close tab should be disabled when the frontmost tab is not a browser or if there is only 1 tab in the window. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16981

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+182 lines, -47 lines)			Patch
M	chrome/app/nibs/en.lproj/MainMenu.xib	View	9 chunks	+35 lines, -47 lines	0 comments	Download
M	chrome/browser/app_controller_mac.h	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/app_controller_mac.mm	View	3 chunks	+112 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/browser_window_controller.mm	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/tab_strip_controller.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/tab_strip_controller.mm	View	3 chunks	+12 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/tab_strip_controller_unittest.mm	View	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

TVL

lgtm do we disable close tab if it's not a tabbed window in the front?

11 years, 7 months ago (2009-05-26 20:45:40 UTC) #2

lgtm

Expand Messages | Collapse Messages