Issue 115772: Run script in ProfLazyMode test longer to improve stability.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115772: Run script in ProfLazyMode test longer to improve stability. (Closed)

Created:
11 years, 7 months ago by Mikhail Naganov

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse, Tobias Kaes

CC:
v8-dev

Visibility:
Public.

Description

Run script in ProfLazyMode test longer to improve stability. Prior to this change debug version of the test crashed 2 of 1000 times. After the change no crashes (out of 1000 runs) occured. Committed: http://code.google.com/p/v8/source/detail?r=2059

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	test/cctest/test-log.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM - but why does this improve stability?

11 years, 7 months ago (2009-05-26 14:14:46 UTC) #2

Tobias Kaes

11 years, 7 months ago (2009-05-26 18:46:34 UTC) #3

The fix looks to me like it's just hiding the problem, not fixing it.
The crashes may be caused by an edge case which gets triggered if the time span
is short.

Expand Messages | Collapse Messages