Issue 115768: On MessageBoxView, do not intercept Ctrl-C by an Accelerator when the...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115768: On MessageBoxView, do not intercept Ctrl-C by an Accelerator when the... (Closed)

Created:
11 years, 7 months ago by tyoshino-do-not-use

Modified:
9 years, 7 months ago

Reviewers:
tony, jcampan

CC:
chromium-reviews_googlegroups.com

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

On MessageBoxView, do not intercept Ctrl-C by an Accelerator when the MessageBox contains a TextField and it's focused. This Accelerator for Ctrl-C was added to fix this bug http://code.google.com/p/chromium/issues/detail?id=5879 , but we must also take into account prompt(). TEST=Enter javascript:prompt('Do not copy me','Copy this!');void(0) into the address bar, and then press Ctrl-C. We should get "Copy this!" into the clipboard. BUG=11872

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	views/controls/message_box_view.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tyoshino-do-not-use

11 years, 7 months ago (2009-05-27 02:09:06 UTC) #3

Thank you for review. Could you please commit this? I'm not a committer.

Expand Messages | Collapse Messages